Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nallo workflow run #4106

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Add nallo workflow run #4106

merged 3 commits into from
Jan 17, 2025

Conversation

peterpru
Copy link
Member

@peterpru peterpru commented Jan 16, 2025

Description

This PR aims to add the cg workflow run function for Nallo.

Added

  • cg workflow run nallo

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b add-nallo-run

How to test

  • Do cg workflow nallo run rightalpaca
  • cg workflow nallo run --from-start rightalpaca --revision dev

Expected test outcome

  • Check that command fails as there is no active tower id for this analysis.
image
  • Command should succeed with --from-start flag:
image
  • Analysis successfully submitted to tower stage:
image

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@peterpru peterpru self-assigned this Jan 16, 2025
@peterpru peterpru added the nallo label Jan 16, 2025
@peterpru peterpru marked this pull request as ready for review January 16, 2025 16:56
@peterpru peterpru requested a review from a team as a code owner January 16, 2025 16:56
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@peterpru peterpru merged commit b36cd1e into master Jan 17, 2025
10 checks passed
@peterpru peterpru deleted the add-nallo-run branch January 17, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants