Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Improve order flow) Add balsamic sample errors #4102

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

islean
Copy link
Contributor

@islean islean commented Jan 16, 2025

Description

Closes https://github.com/Clinical-Genomics/improve-order-flow/issues/133.

Added

  • Rule preventing more than two samples in any Balsamic case
  • Rule preventing a double tumour pair in any Balsamic case
  • Rule preventing a double normal pair in any Balsamic case

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean requested a review from a team as a code owner January 16, 2025 12:35
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ⭐ I think you forgot to add the second validation to the validation rules

@islean
Copy link
Contributor Author

islean commented Jan 16, 2025

Tested on stage:

Max one tumour:

image

Max one normal:

image

Max 2 samples:

image

@islean islean merged commit f0a7419 into improve-order-flow-main Jan 16, 2025
8 checks passed
@islean islean deleted the add-balsamic-sample-errors branch January 16, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants