Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nallo cg workflow config-case #4098

Merged
merged 9 commits into from
Jan 16, 2025
Merged

add nallo cg workflow config-case #4098

merged 9 commits into from
Jan 16, 2025

Conversation

peterpru
Copy link
Member

@peterpru peterpru commented Jan 15, 2025

Description

Add nallo config-case. This generates 3 files needed to start the analysis in nextflow.

For the reviewer: this is the same as for raredisease, except for three things.

  1. For nallo we need bam file paths as input for the sample sheet instead of fastq files. In this PR the bam file paths are collected from housekeeper.
  2. For the nallo pipeline we need the sample sheet to have maximum one bam file per line. Instead of having having one sample per line in the samplsheet, we can have multiple. Here the all bam file paths are collected, and for each bam file entry, it will create a sample entry in the sample sheet.
  3. no resolve-decompression. Input is bamfiles, so we can skip the entire spring->fastq checking and decompressing.

Added

  • cg workflow nallo config-case

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b add-nallo-config-case

How to test

  • Do cg workflow nallo config-case rightalpaca

Expected test outcome

  • The command should create a rightalpaca_samplesheet.csv, params file and config.yaml
  • Files should have content, where params and config are populated from servers, and samplesheet from cg.
  • Take a screenshot and attach or copy/paste the output.
image

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@peterpru peterpru self-assigned this Jan 15, 2025
@peterpru peterpru added the nallo label Jan 16, 2025
@peterpru peterpru marked this pull request as ready for review January 16, 2025 10:24
@peterpru peterpru requested a review from a team as a code owner January 16, 2025 10:24
Copy link
Contributor

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

cg/meta/workflow/nallo.py Outdated Show resolved Hide resolved
cg/meta/workflow/nf_analysis.py Outdated Show resolved Hide resolved
@peterpru peterpru merged commit 50a5b76 into master Jan 16, 2025
10 checks passed
@peterpru peterpru deleted the add-nallo-config-case branch January 16, 2025 12:36
@peterpru
Copy link
Member Author

Thanks for the review @Vince-janv

Deployed in stage:
image

Deployed in production:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants