Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(FOHM and GSAID to upload API) #4028

Merged
merged 4 commits into from
Dec 17, 2024
Merged

add(FOHM and GSAID to upload API) #4028

merged 4 commits into from
Dec 17, 2024

Conversation

ChrOertlin
Copy link
Contributor

@ChrOertlin ChrOertlin commented Dec 16, 2024 •
edited
Loading

Description

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b fohm-gsaid-in-upload -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@ChrOertlin ChrOertlin requested a review from a team as a code owner December 16, 2024 15:18
@ChrOertlin ChrOertlin marked this pull request as draft December 16, 2024 15:20
@ChrOertlin ChrOertlin marked this pull request as ready for review December 17, 2024 08:48
@ChrOertlin ChrOertlin mentioned this pull request Dec 17, 2024
Closed
1 task
islean
islean approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just the try/catch that is a bit cryptic to me

cg/meta/upload/mutant/mutant.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ChrOertlin
Copy link
Contributor Author

tests

cg upload -c
delivered files to cust, to fohm upload and tried to sync

@ChrOertlin ChrOertlin merged commit 9054b1b into mutant-file-formatter Dec 17, 2024
9 checks passed
@ChrOertlin ChrOertlin deleted the fohm-gsaid-in-upload branch December 17, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrOertlin @islean