Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework microbial fastq store #4026

Merged
merged 10 commits into from
Dec 19, 2024

Conversation

diitaz93
Copy link
Contributor

@diitaz93 diitaz93 commented Dec 16, 2024

Description

Closes https://github.com/Clinical-Genomics/improve-order-flow/issues/111
Rework the Microbial Fastq storing service

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@diitaz93 diitaz93 marked this pull request as ready for review December 18, 2024 09:56
@diitaz93 diitaz93 requested a review from a team as a code owner December 18, 2024 09:56
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super nice! But do we not need to rework the microbialordersubmitter a bit and enable some ignored tests? Also - have we tested placing an order on stage?

Copy link
Contributor

@ChrOertlin ChrOertlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here look good

@ChrOertlin
Copy link
Contributor

Looks super nice! But do we not need to rework the microbialordersubmitter a bit and enable some ignored tests? Also - have we tested placing an order on stage?

I reckon all order submitters require some rework, but that seems out of scope for this PR.

@islean
Copy link
Contributor

islean commented Dec 18, 2024

Looks super nice! But do we not need to rework the microbialordersubmitter a bit and enable some ignored tests? Also - have we tested placing an order on stage?

I reckon all order submitters require some rework, but that seems out of scope for this PR.

I guess it might be, but the submitters are almost superfluous at this point. We should stake out what is within scope but if it is to have the same scope as the minimal implementation fastq rework, then the submitter is included in scope

@diitaz93 diitaz93 merged commit bb78b45 into improve-order-flow-main Dec 19, 2024
9 checks passed
@diitaz93 diitaz93 deleted the rework-microbial-fastq-store branch December 19, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants