-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework microbial fastq store #4026
rework microbial fastq store #4026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super nice! But do we not need to rework the microbialordersubmitter a bit and enable some ignored tests? Also - have we tested placing an order on stage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here look good
I reckon all order submitters require some rework, but that seems out of scope for this PR. |
I guess it might be, but the submitters are almost superfluous at this point. We should stake out what is within scope but if it is to have the same scope as the minimal implementation fastq rework, then the submitter is included in scope |
Quality Gate passedIssues Measures |
Description
Closes https://github.com/Clinical-Genomics/improve-order-flow/issues/111
Rework the Microbial Fastq storing service
How to prepare for test
us
paxa
How to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan