Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(decompose sample file formatter) #3960

Merged
merged 6 commits into from
Nov 25, 2024
Merged

refactor(decompose sample file formatter) #3960

merged 6 commits into from
Nov 25, 2024

Conversation

ChrOertlin
Copy link
Contributor

@ChrOertlin ChrOertlin commented Nov 21, 2024 •
edited
Loading

Description

Decompose the logic in the SampleFileFormatter into smaller modules.

The extraction of the logic into smaller modules is also beneficial for this issue: #3910 as some functionality is needed there as well

Part of #3916

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b decompose-sample-file-formatter -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@ChrOertlin ChrOertlin requested a review from a team as a code owner November 21, 2024 14:48
islean
islean approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I wonder if we can get the benefits from the dependency injection and use default values or if that defeats the added clarity in what is needed.

cg/services/deliver_files/deliver_files_service/deliver_files_service_factory.py Show resolved Hide resolved
cg/services/deliver_files/deliver_files_service/deliver_files_service_factory.py Show resolved Hide resolved
cg/services/deliver_files/file_formatter/utils/sample_service.py Outdated Show resolved Hide resolved
cg/services/deliver_files/file_formatter/utils/sample_service.py Outdated Show resolved Hide resolved
cg/services/deliver_files/file_formatter/utils/sample_service.py Outdated Show resolved Hide resolved
cg/services/deliver_files/file_formatter/utils/sample_concatenation_service.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ChrOertlin ChrOertlin merged commit 6a9ddb8 into master Nov 25, 2024
9 checks passed
@ChrOertlin ChrOertlin deleted the decompose-sample-file-formatter branch November 25, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrOertlin @islean