Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(post processing when samples missing) #3839

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

ChrOertlin
Copy link
Contributor

@ChrOertlin ChrOertlin commented Oct 11, 2024

Description

Stop processing of a flow cell as soon as a missing sample is detected, does a rollback when such issue is encountered.

Not having samples that are present on a flow cell in statusdb is an indicator something went wrong upstream and should not happen.

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@ChrOertlin ChrOertlin requested a review from a team as a code owner October 11, 2024 09:58
Copy link
Contributor

@ahdamin ahdamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead ..!

Copy link

@ChrOertlin
Copy link
Contributor Author

image

@ChrOertlin ChrOertlin merged commit b20022a into master Oct 14, 2024
9 checks passed
@ChrOertlin ChrOertlin deleted the fix-post-processing-error branch October 14, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants