Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clashing ticket ids #3833

Merged
merged 11 commits into from
Oct 14, 2024
Merged

Fix clashing ticket ids #3833

merged 11 commits into from
Oct 14, 2024

Conversation

islean
Copy link
Contributor

@islean islean commented Oct 10, 2024

Description

This PR reworks filtering on ticket ids to go via the Order table instead of the tickets column found in the Case table. Closes #3702

Added

Changed

  • Filtering on ticket id is done in the Order table

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b fix-ticket-clashes -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean marked this pull request as ready for review October 10, 2024 14:07
@islean islean requested a review from a team as a code owner October 10, 2024 14:07
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

cg/store/base.py Outdated Show resolved Hide resolved
cg/store/base.py Show resolved Hide resolved
cg/store/crud/read.py Show resolved Hide resolved
Copy link

@islean
Copy link
Contributor Author

islean commented Oct 14, 2024

Tested:

Ran cg decompress ticket <ticket_id> and it successfully chose the relevant sample

@islean islean merged commit 160beaf into master Oct 14, 2024
9 checks passed
@islean islean deleted the fix-ticket-clashes branch October 14, 2024 13:12
@islean
Copy link
Contributor Author

islean commented Oct 14, 2024

Deployed to Hasta:

done.
Log deploy... done.
cg, version 63.5.13
remote: Enumerating objects: 11, done.
remote: Counting objects: 100% (11/11), done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 11 (delta 4), reused 9 (delta 4), pack-reused 0 (from 0)
Unpacking objects: 100% (11/11), done.
From https://github.com/Clinical-Genomics/cg
   d6422d3..af54aaa  master     -> origin/master
 * [new tag]         v63.5.13   -> v63.5.13
Already on 'master'
Your branch is behind 'origin/master' by 2 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)
Updating d6422d3..af54aaa
Fast-forward
 .bumpversion.cfg                                 |  2 +-
 cg/__init__.py                                   |  2 +-
 cg/store/base.py                                 | 13 ++++++++++++-
 cg/store/crud/read.py                            | 27 ++++++++++++++-------------
 cg/store/filters/status_case_filters.py          |  6 ------
 pyproject.toml                                   |  2 +-
 tests/store/filters/test_status_cases_filters.py | 31 -------------------------------
 tests/store/filters/test_status_order_filters.py | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/store_helpers.py                           |  7 ++++++-
 9 files changed, 86 insertions(+), 55 deletions(-)
 create mode 100644 tests/store/filters/test_status_order_filters.py
/home/isak.ohlsson
INFO  [alembic.runtime.migration] Context impl MySQLImpl.
INFO  [alembic.runtime.migration] Will assume non-transactional DDL.
[isak.ohlsson@hasta:~] [P_base] $ 

@islean islean mentioned this pull request Oct 24, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Freshdesk tickets may match SuSy ticket ids
2 participants