Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store all fastq files for negative controls) #3681

Merged
merged 3 commits into from
Sep 4, 2024
Merged

feat(store all fastq files for negative controls) #3681

merged 3 commits into from
Sep 4, 2024

Conversation

beatrizsavinhas
Copy link
Contributor

@beatrizsavinhas beatrizsavinhas commented Sep 3, 2024 •
edited
Loading

Description

Part of #2871

Added

  • Check to store all fastq files for negative control samples.

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@beatrizsavinhas beatrizsavinhas changed the title Add check for negative controls when storing fastq files. feat(store all fastq files for negative controls) Sep 3, 2024
@beatrizsavinhas beatrizsavinhas marked this pull request as ready for review September 4, 2024 07:38
@beatrizsavinhas beatrizsavinhas requested a review from a team as a code owner September 4, 2024 07:38
islean
islean approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@beatrizsavinhas beatrizsavinhas merged commit c4103e4 into master Sep 4, 2024
9 checks passed
@beatrizsavinhas beatrizsavinhas deleted the 2871-store-fastq-hk-negative-controls branch September 4, 2024 08:32
@Karl-Svard Karl-Svard mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vince-janv Vince-janv Vince-janv left review comments

@islean islean islean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beatrizsavinhas @islean @Vince-janv