-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add models for existing samples and cases #3648
Conversation
cg/services/order_validation_service/models/order_with_cases.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that we parse the data into the correct models 🚀
That way, we can actually use the basic pydantic validation to a greater extent in the validation logic which I think removes some bloat.
Quality Gate passedIssues Measures |
Description
This PR separates the new and existing cases and samples into separate Pydantic models.
Added
Changed
Fixed
How to prepare for test
us
paxa
How to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan