Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add models for existing samples and cases #3648

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

islean
Copy link
Contributor

@islean islean commented Aug 27, 2024

Description

This PR separates the new and existing cases and samples into separate Pydantic models.

Added

  • ExistingSample
  • ExistingCase

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean requested a review from a team as a code owner August 27, 2024 14:00
Copy link
Contributor

@seallard seallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that we parse the data into the correct models 🚀

That way, we can actually use the basic pydantic validation to a greater extent in the validation logic which I think removes some bloat.

Copy link

@islean islean merged commit 2e58c32 into improve-order-flow-main Aug 28, 2024
8 checks passed
@islean islean deleted the add-existing-sample-model branch August 28, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants