Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(delivery service factory) #3647

Merged
merged 41 commits into from
Aug 29, 2024
Merged

add(delivery service factory) #3647

merged 41 commits into from
Aug 29, 2024

Conversation

ChrOertlin
Copy link
Contributor

Description

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

ChrOertlin and others added 30 commits August 21, 2024 16:09
@ChrOertlin
initial commit
4dd94c8
@ChrOertlin
fixes
c09db2f
@ChrOertlin
fix
f449da4
@ChrOertlin
add test
33456ef
@ChrOertlin
fix test
f175540
@ChrOertlin
add exists assertion
511ed7f
@ChrOertlin
add func call
9063fc8
@ChrOertlin
initial commit
8a64d3b
@ChrOertlin @henrikstranneheim
Update tests/fixture_plugins/delivery_fixtures/delivery_files_models_…
83d6c9f 
…fixtures.py

Co-authored-by: Henrik Stranneheim <[email protected]>
@ChrOertlin @henrikstranneheim
Update tests/fixture_plugins/delivery_fixtures/delivery_files_models_…
bacaa11 
…fixtures.py

Co-authored-by: Henrik Stranneheim <[email protected]>
@ChrOertlin @henrikstranneheim
Apply suggestions from code review
0533071 
Co-authored-by: Henrik Stranneheim <[email protected]>
@ChrOertlin
review
3fbc9ef
@ChrOertlin
Merge branch 'add-file-mover' into add-file-reformatters
4eca28e
@ChrOertlin
conflicsts
f83f694
@ChrOertlin
refactor logic
652938e
@ChrOertlin
fix formatter
1aad85b
@ChrOertlin
fix concatenation
6cabd68
@ChrOertlin
tests
56d7ec1
@ChrOertlin
add tests for formatters
2845d05
@ChrOertlin
add test
481c518
@ChrOertlin
review comments
293ee09
@ChrOertlin
setup factory
273f19f
@ChrOertlin
add supporting functions
981395f
@ChrOertlin
make super call
db99c05
@ChrOertlin
Merge branch 'add-file-reformatters' into add-delivery-services
e187522
@ChrOertlin
changes
6ab6d5e
@ChrOertlin
simplifiy formatter
93056cd
@ChrOertlin
add docstring
c13ce34
@ChrOertlin
solve imports
5d1ddb9
@ChrOertlin
Merge branch 'add-file-reformatters' into add-delivery-services
ebcf010
@ChrOertlin ChrOertlin requested a review from a team as a code owner August 27, 2024 12:58
@ChrOertlin ChrOertlin marked this pull request as draft August 27, 2024 13:12
@ChrOertlin ChrOertlin changed the base branch from dev-new-delivery-service to add-file-reformatters August 28, 2024 07:10
@ChrOertlin ChrOertlin marked this pull request as ready for review August 28, 2024 07:10
Base automatically changed from add-file-reformatters to dev-new-delivery-service August 29, 2024 06:36
islean
islean approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

cg/services/file_delivery/deliver_files_service/deliver_files_service_factory.py Show resolved Hide resolved
cg/services/file_delivery/fetch_file_service/fetch_fastq_analysis_files_service.py Outdated Show resolved Hide resolved
cg/services/file_delivery/deliver_files_service/deliver_files_service_factory.py Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ChrOertlin ChrOertlin merged commit f04e95f into dev-new-delivery-service Aug 29, 2024
7 checks passed
@ChrOertlin ChrOertlin deleted the add-delivery-service-factory branch August 29, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlnyr karlnyr karlnyr left review comments

@islean islean islean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrOertlin @islean @karlnyr