Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mip dna rules #3625

Merged
merged 15 commits into from
Aug 26, 2024
Merged

Add mip dna rules #3625

merged 15 commits into from
Aug 26, 2024

Conversation

seallard
Copy link
Contributor

@seallard seallard commented Aug 22, 2024

Add mip-dna rules (same as for tomte). Fixed type hints using aliases as agreed.

Closes #3614

@seallard seallard marked this pull request as ready for review August 22, 2024 12:55
@seallard seallard requested a review from a team as a code owner August 22, 2024 12:55
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments! I also think we need a MipDnaOrder class to appropriately type hint the delivery type

@seallard seallard merged commit 3e15529 into improve-order-flow-main Aug 26, 2024
5 checks passed
@seallard seallard deleted the add-mip-dna-rules branch August 26, 2024 12:31
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants