-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat - new sample sheet validation #2944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Seems like most cases are covered in the validation. However, I think that there are a few pints that may need another look.
for row in self.content: | ||
if not row: | ||
continue | ||
if SampleSheetBCLConvertSections.Data.HEADER in row[0]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't be in row one right? Will not SampleSheetBCLConvertSections.Header.HEADER be the first thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly, SampleSheetBCLConvertSections.Header.HEADER, which is [Header]
will be the first thing, but SampleSheetBCLConvertSections.Data.HEADER which is [BCLConvert_Data]
will be further down
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to create one validation that fails? We have here the one where the sample sheet is missing, but do we want to assume it just works as well?
Quality Gate passedIssues Measures |
Description
Fix #2922: Create a more strict validation for v2 sample sheets.
This PR implements a new validation for v2 sample sheets that takes into account 5 aspects:
[Header]
[Reads]
[BCLConvert_Settings]
[BCLConvert_Data]
IndexSettings
is present in the[Header]
of the sample sheet[Reads]
section and are valid[BCLConvert_Data]
section has the correct columns (sample validation)[Reads]
section and the index2 cycles are in the correct format according to theIndexSettings
(reverse or forward).Added
SampleSheetValidator
with the endpoint functionvalidate_sample_sheet
which will be the new function to validate sample sheets.OverrideCyclesValidator
with the endpoint functionvalidate_sample
which will validate if the override cycles for a single sample is correct. It is called for each sample inside theSampleSheetValidator
.Changed
validate_sample_sheet
(cg demultiplex samplesheet validate
) uses now the new validation.Fixed
How to prepare for test
us
paxa
How to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan