refactor - Organise lims samples fixtures

[diitaz93]

Description

This is the first step of #2842. Refactor the fixtures returning lists of FlowCellSample to only use elements from the 7 canonical flow cells in demultiplexing

Added

• Raw sample file tests/fixtures/apps/demultiplexing/flow_cells/190927_A00689_0069_BHLYWYDSXX/HLYWYDSXX_bcl2fastq_raw.json with anonymised names and projects

Changed

• Renamed novaseq_6000_pre_1_5_kits_lims_samples and novaseq_6000_post_1_5_kits_lims_samples to explicitly include the bcl converter in their name

Fixed

• Removed fixture lims_novaseq_6000_bcl2fastq_samples, replaced usages with novaseq_6000_pre_1_5_kits_bcl2fastq_lims_samples.
• Removed fixture lims_novaseq_bcl_convert_samples, replaced usages with novaseq_x_lims_samples
• Removed paths to lims sample files that were used only once. Instantiated Path in the fixture where they were used instead.

How to prepare for test

• Ssh to relevant server (depending on type of change)
• Use stage: us
• Paxa the environment: paxa
• Install on stage (example for Hasta):

  bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

• Do ...

Expected test outcome

• Check that ...
• Take a screenshot and attach or copy/paste the output.

Review

• Tests executed by
• "Merge and deploy" approved by
  Thanks for filling in who performed the code review and the test!

This version is a

• MAJOR - when you make incompatible API changes
• MINOR - when you add functionality in a backwards compatible manner
• PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

• Document in ...
• Deploy this branch on ...
• Inform to ...

[ChrOertlin]

💯

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[diitaz93]

Deployed to stage and production