Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable microsalt upload command #2823

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Enable microsalt upload command #2823

merged 2 commits into from
Jan 11, 2024

Conversation

seallard
Copy link
Contributor

Description

Add microsalt support for cg upload -c.

Added

  • Microsalt cases can now be uploaded via cg upload

This version is a

  • MINOR - when you add functionality in a backwards compatible manner

@seallard seallard requested a review from a team as a code owner January 11, 2024 11:52
@seallard seallard changed the title Add microsalt upload api Enable microsalt upload command Jan 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@seallard
Copy link
Contributor Author

Tested in stage

islean
islean approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have some small comments, mostly regarding preexisting code.

cg/meta/upload/microsalt/microsalt_upload_api.py Show resolved Hide resolved
cg/meta/upload/microsalt/microsalt_upload_api.py Show resolved Hide resolved
cg/cli/upload/base.py Show resolved Hide resolved
cg/cli/upload/base.py Show resolved Hide resolved
@seallard seallard merged commit 62a1840 into master Jan 11, 2024
9 checks passed
@seallard seallard deleted the fix-microsalt-upload branch January 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seallard @islean