Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sql): Refactor delete and update handler #2808

Merged

Conversation

henrikstranneheim
Copy link
Contributor

@henrikstranneheim henrikstranneheim commented Jan 8, 2024

Description

Added

Changed

  • Move delete and update to CRUD namespace

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b refactor-sql-deletehandler-and-updatehandler -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

Copy link
Contributor

@ChrOertlin ChrOertlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Nice!

Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cg/store/crud/delete.py Outdated Show resolved Hide resolved
@henrikstranneheim henrikstranneheim changed the title fest(sql): Refactor delete and update handler feat(sql): Refactor delete and update handler Jan 11, 2024
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@henrikstranneheim
Copy link
Contributor Author

cg get case justhusky 👍

|----------------+-----------------+------------+---------------+--------------------+------------+-------------|
| hugelymodelbat | ACC5339A4--300M | cust000    | WGXCUSC000    | Ordered 2019-05-08 | priority   | Yes         |
+----------------+-----------------+------------+---------------+--------------------+------------+-------------+
+---------------------+------------+-----------+
| Analysis Date       | Pipeline   | Version   |
|---------------------+------------+-----------|
| 2023-12-07 10:32:30 | mip-dna    | 12.0.3    |
+---------------------+------------+-----------+

@henrikstranneheim henrikstranneheim merged commit ad6766b into master Jan 12, 2024
9 checks passed
@henrikstranneheim henrikstranneheim deleted the refactor-sql-deletehandler-and-updatehandler branch January 12, 2024 07:03
@henrikstranneheim
Copy link
Contributor Author

Deployed in production:

Log deploy... done.
cg, version 55.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants