Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Archiving) Refactor DDN flow #2766

Merged
merged 5 commits into from
Dec 14, 2023
Merged

(Archiving) Refactor DDN flow #2766

merged 5 commits into from
Dec 14, 2023

Conversation

islean
Copy link
Contributor

@islean islean commented Dec 13, 2023

Description

This PR splits the ddn_dataflow.py module up into three modules all in the DDN package. We have

  • ddn_data_flow_client.py which houses mainly the class DDNDataFlowClient
  • models.py which houses the many base models used in the DDN flow
  • constants.py which houses the constants used in the DDN flow.

Changed

  • Split the ddn_data_flow.py module into three and encapsulated them in a DDN package.

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b archiving-refactor-ddn -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean self-assigned this Dec 13, 2023
@islean islean marked this pull request as ready for review December 13, 2023 14:35
@islean islean requested a review from a team as a code owner December 13, 2023 14:35
Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

cg/meta/archive/ddn/constants.py Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@islean
Copy link
Contributor Author

islean commented Dec 14, 2023

Tested archiving files:

Files submitted to karolinska_bucket with archival task id 194.
Adding an archive to file 5057623 with archiving task id 194
Adding an archive to file 5057624 with archiving task id 194
1d [isak.ohlsson@hasta:~] [S_base] 28s $ 

update-job-statuses:

Miria returned status Completed for job 194
Job with id 194 has finished, updating Archive entries.

Reflected in the db:
image
Delete one file:

Deleting file /home/proj/stage/housekeeper-bundles/isaks_test_bundle/2023-12-06/isaks_test_spring_file.spring from disc
Deleting file 5057623 from housekeeper
image

@islean islean merged commit 2a2baa0 into master Dec 14, 2023
8 checks passed
@islean islean deleted the archiving-refactor-ddn branch December 14, 2023 12:18
@islean
Copy link
Contributor Author

islean commented Dec 14, 2023

Deployed to production:

Logging deploy ...
Getting deployer... done.
Getting last commit message and SHA... done.
Getting version of deploy scripts... /home/isak.ohlsson
done.
Log deploy... done.
cg, version 54.4.6
1d [isak.ohlsson@hasta:~] [P_base] 2m28s $ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants