Add column to determine if eligible for skip qc #2758
Conversation
|
|
Downgrade successful: |
| def upgrade(): | ||
| op.add_column( | ||
| "application", | ||
| sa.Column("is_eligible_for_skip_qc", sa.Boolean(), nullable=False), |
There was a problem hiding this comment.
Might be necessary to provide a default value to the column here as well?
There was a problem hiding this comment.
but maybe a good idea to set it to False as default, not sure.
There was a problem hiding this comment.
A bit unsure what it would add, given that the script has already been tested and added the column with False as default.
|
Kudos, SonarCloud Quality Gate passed!
|
It won't be an automatic thing, rather that lab or production need to be able to set this manually when adding new Applications. Or at least that is my understanding currently, need to check whether this solution is satisfactory. |
|
Upon discussion, this will start out as the customer's responsibility. So for now there is no reason to add this functionality. |
Description
As part of the ongoing developments to let some customers bypass our qc, we need to keep track of which applications are allowed. The ones currently allowed are described here https://github.com/Clinical-Genomics/project-planning/issues/485#issuecomment-1845032498. This PR adds a column to the Application table which shows whether the application is eligible for skipping qc.
Added
is_eligible_for_skip_qccolumn to the Application table.How to prepare for test
uspaxaHow to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan