Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added method get_managed_variants to mip rna workflow #2757

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

diitaz93
Copy link
Contributor

@diitaz93 diitaz93 commented Dec 11, 2023

Description

The MipRNAAnalysisAPI didn't have a get_managed_variants method which raised an error when running cg workflow mip-rna start -sa star_fusion hugewasp

Added

  • Method get_managed_variants to MipRNAAnalysisAPI

Changed

  • Moved method write_managed_variants from MipDNAAnalysisAPI to MipAnalysisAPI so that it is available also for MipRNA

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@diitaz93 diitaz93 marked this pull request as ready for review December 11, 2023 14:02
@diitaz93 diitaz93 requested a review from a team as a code owner December 11, 2023 14:02
@diitaz93 diitaz93 requested a review from peterpru December 11, 2023 14:02
Copy link
Member

@peterpru peterpru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a code owner, so you might need sysdev 💯

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🔥 ⚡

@diitaz93 diitaz93 merged commit dc8cd7d into master Dec 11, 2023
9 checks passed
@diitaz93 diitaz93 deleted the fix-managed-variants-mip-rna branch December 11, 2023 14:34
@diitaz93
Copy link
Contributor Author

Deployed to stage:

Logging deploy ...
Getting deployer... done.
Getting last commit message and SHA... done.
Getting version of deploy scripts... /home/proj/stage/flow_cells/180509_D00450_0598_BHGYFNBCX2
done.
Log deploy... done.
cg, version 54.2.1
θ61° 3d [js.diazboada@hasta:

Deployed to production:

Logging deploy ...
Getting deployer... done.
Getting last commit message and SHA... done.
Getting version of deploy scripts... /home/proj/stage/flow_cells/180509_D00450_0598_BHGYFNBCX2
done.
Log deploy... done.
cg, version 54.2.1
θ61° 3d [js.diazboada@hasta:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants