Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse new concentration field #2740

Merged
merged 13 commits into from
Dec 20, 2023
Merged

Parse new concentration field #2740

merged 13 commits into from
Dec 20, 2023

Conversation

islean
Copy link
Contributor

@islean islean commented Dec 6, 2023

Description

Part of the new order form was to add a new field where the customer can set concentration on sample level in ng/ul. This is intended to be used when considering a bypass of the quality control. This PR makes sure that we parse this value.

Changed

  • Added field to hold new concentration field.

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@clingen-sthlm clingen-sthlm temporarily deployed to stage December 6, 2023 14:07 Inactive
@islean
Copy link
Contributor Author

islean commented Dec 6, 2023

Works with Excel fields via the new order portal: where the concentration field was parsed from the order form.
image

@islean islean self-assigned this Dec 11, 2023
@clingen-sthlm clingen-sthlm temporarily deployed to stage December 13, 2023 14:44 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage December 13, 2023 15:21 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage December 14, 2023 09:58 Inactive
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@islean islean marked this pull request as ready for review December 19, 2023 15:01
@islean islean requested a review from a team as a code owner December 19, 2023 15:01
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@islean islean merged commit 9411fb5 into master Dec 20, 2023
9 checks passed
@islean islean deleted the parse-concentration branch December 20, 2023 08:07
@islean islean mentioned this pull request Dec 22, 2023
15 tasks
karlnyr pushed a commit that referenced this pull request Jan 31, 2024
### Changed

- Added field to hold new concentration field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants