Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add raredisease config #2725

Merged
merged 190 commits into from
Mar 4, 2024
Merged

add raredisease config #2725

merged 190 commits into from
Mar 4, 2024

Conversation

peterpru
Copy link
Member

@peterpru peterpru commented Dec 1, 2023

Description

This PR adds support for the command cg workflow raredisease config-case

Added

  • click command config-case

Changed

  • Option from-start is now common for all nf-analyses

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that config-case is an option when doing cg workflow raredisease --help
    image

  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@rannick rannick added the raredisease Issues related to nextflow raredisease pipeline label Dec 4, 2023
@rannick
Copy link
Contributor

rannick commented Mar 4, 2024

This should be ready for re-review!

cg/io/config.py Outdated Show resolved Hide resolved
cg/io/config.py Outdated Show resolved Hide resolved
cg/io/txt.py Outdated Show resolved Hide resolved
cg/meta/workflow/raredisease.py Outdated Show resolved Hide resolved
cg/store/models.py Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rannick rannick merged commit dd59c1a into master Mar 4, 2024
9 checks passed
@rannick rannick deleted the add-raredisease-config-case branch March 4, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
raredisease Issues related to nextflow raredisease pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants