Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Archiving) Modify according to documentation #2692

Merged
merged 13 commits into from
Nov 27, 2023

Conversation

islean
Copy link
Contributor

@islean islean commented Nov 15, 2023

Description

With the catalogue and data mover servers being up and running, we need to modify some parts of the flow, now that we can take part of the documentation. This is a pre-PR needed to test some functionality when the CLI functionality is added as well.

Changed

  • Get job status endpoint, request and response.
  • Aliases for camel case responses.

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b archiving-correct-requests-responses -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean marked this pull request as ready for review November 20, 2023 14:09
@islean islean requested a review from a team as a code owner November 20, 2023 14:09
@islean islean self-assigned this Nov 20, 2023
Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

cg/meta/archive/ddn_dataflow.py Outdated Show resolved Hide resolved
cg/meta/archive/ddn_dataflow.py Outdated Show resolved Hide resolved
cg/meta/archive/ddn_dataflow.py Outdated Show resolved Hide resolved
tests/meta/archive/conftest.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@islean
Copy link
Contributor Author

islean commented Nov 27, 2023

Deployed and the CLI was responsive. Since no live functionality is added, testing is deemed successful //IO

@islean islean merged commit c2fdd8c into master Nov 27, 2023
9 checks passed
@islean islean deleted the archiving-correct-requests-responses branch November 27, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants