Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Balsamic API (Balsamic v13 release) #2657

Merged
merged 103 commits into from
Jan 22, 2024
Merged

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Nov 6, 2023

Description

Changes are summarised in: #2447

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b remove-concatenation-balsamic -a

How to test

  • cg workflow <balsamic/umi/qc> start
  • cg workflow <balsamic/umi/qc> store
  • cg upload -c

Expected test outcome

  • Analysis API can start cases without concatenating the FASTQs
  • Cases can be stored
  • Cases can be uploaded (clinical delivery, scout, gens, etc.)

More information regarding the system integration tests: Clinical-Genomics/BALSAMIC#1320 (comment)

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

ivadym added 30 commits July 4, 2023 17:33
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ivadym ivadym merged commit fe78f34 into master Jan 22, 2024
9 checks passed
@ivadym ivadym deleted the remove-concatenation-balsamic branch January 22, 2024 09:01
@ivadym
Copy link
Contributor Author

ivadym commented Jan 22, 2024

Deployed:

Screenshot 2024-01-22 at 10 10 27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Balsamic v13 release changes
3 participants