Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add raredisease to cli cg workflow #2649

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Conversation

peterpru
Copy link
Member

@peterpru peterpru commented Oct 31, 2023

Description

This PR aims to add raredisease as a cli option in cg workflow. This is a redo of PR #2592, which failed on deployment and was reverted in #2646. The code in this PR is the same as in the first PR.

Added

  • cli option raredisease for cg workflow

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b add-raredisease-to-workflow -a

How to test

  • Do cg workflow --help

Expected test outcome

  • cg workflow shows the new option:

image

  • Check that installing on stage shows that the alembic revision is installed correctly.
  • When completing the tests, pull master and show that the alembic downgrade completed successfully.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@peterpru peterpru requested a review from a team as a code owner October 31, 2023 10:56
@clingen-sthlm clingen-sthlm temporarily deployed to stage October 31, 2023 11:40 Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@seallard seallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@peterpru
Copy link
Member Author

Successfully installed on stage:
image

@peterpru peterpru merged commit db8213c into master Oct 31, 2023
8 checks passed
@peterpru peterpru deleted the add-raredisease-to-workflow branch October 31, 2023 13:50
@peterpru
Copy link
Member Author

Thank you very much for the help @seallard :
image

Deployed in prod:
image

@peterpru peterpru self-assigned this Sep 18, 2024
@peterpru peterpru added the raredisease Issues related to nextflow raredisease pipeline label Sep 18, 2024
@peterpru peterpru mentioned this pull request Jan 13, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
raredisease Issues related to nextflow raredisease pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants