Skip to content

Commit

Permalink
rename service
Browse files Browse the repository at this point in the history
  • Loading branch information
diitaz93 committed Oct 11, 2024
1 parent 35254c0 commit 4e1977f
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions cg/services/run_devices/run_names/pacbio.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
from pathlib import Path

from cg.services.run_devices.run_names.service import RunNamesService
from cg.services.run_devices.run_names.service import RunDirectoryNamesService


class PacbioRunNamesService(RunNamesService):
class PacbioRunDirectoryNamesService(RunDirectoryNamesService):

def get_run_names(self) -> list[str]:
"""
Expand Down
2 changes: 1 addition & 1 deletion cg/services/run_devices/run_names/service.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from abc import ABC, abstractmethod


class RunNamesService(ABC):
class RunDirectoryNamesService(ABC):

def __init__(self, run_directory: str):
self.run_directory = run_directory
Expand Down
6 changes: 3 additions & 3 deletions tests/fixture_plugins/pacbio_fixtures/service_fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
PacBioRunDataGenerator,
)
from cg.services.run_devices.pacbio.run_file_manager.run_file_manager import PacBioRunFileManager
from cg.services.run_devices.run_names.pacbio import PacbioRunNamesService
from cg.services.run_devices.run_names.pacbio import PacbioRunDirectoryNamesService
from cg.store.store import Store


Expand All @@ -36,8 +36,8 @@ def pac_bio_run_file_manager() -> PacBioRunFileManager:


@pytest.fixture
def pacbio_run_names_service(pac_bio_runs_dir: Path) -> PacbioRunNamesService:
return PacbioRunNamesService(run_directory=pac_bio_runs_dir.as_posix())
def pacbio_run_names_service(pac_bio_runs_dir: Path) -> PacbioRunDirectoryNamesService:
return PacbioRunDirectoryNamesService(run_directory=pac_bio_runs_dir.as_posix())


@pytest.fixture
Expand Down
10 changes: 5 additions & 5 deletions tests/services/run_names/test_pacbio_run_names_service.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
from pathlib import Path

from cg.services.run_devices.run_names.pacbio import PacbioRunNamesService
from cg.services.run_devices.run_names.pacbio import PacbioRunDirectoryNamesService


def test_pacbio_get_run_names(
pacbio_run_names_service: PacbioRunNamesService, pacbio_run_names: set
pacbio_run_names_service: PacbioRunDirectoryNamesService, pacbio_run_names: set
):
"""Test that getting PacBio run names works."""
# GIVEN a PacBio run names service
Expand All @@ -18,7 +18,7 @@ def test_pacbio_get_run_names(

def test_pacbio_get_run_names_empty(tmp_path: Path):
# GIVEN a run directory with no run folders and a PacBio run names service
pacbio_run_names_service: PacbioRunNamesService = PacbioRunNamesService(
pacbio_run_names_service: PacbioRunDirectoryNamesService = PacbioRunDirectoryNamesService(
run_directory=tmp_path.as_posix()
)

Expand All @@ -35,7 +35,7 @@ def test_pacbio_get_run_names_with_files_return_emty(tmp_path: Path):
run_dir.mkdir()
Path(run_dir, "file1").touch()
Path(run_dir, "file2").touch()
pacbio_run_names_service: PacbioRunNamesService = PacbioRunNamesService(
pacbio_run_names_service: PacbioRunDirectoryNamesService = PacbioRunDirectoryNamesService(
run_directory=run_dir.as_posix()
)

Expand All @@ -52,7 +52,7 @@ def test_pacbio_get_run_names_with_subfolders_return_empty(tmp_path: Path):
run_dir.mkdir()
subfolder = Path(run_dir, "subfolder")
subfolder.mkdir()
pacbio_run_names_service: PacbioRunNamesService = PacbioRunNamesService(
pacbio_run_names_service: PacbioRunDirectoryNamesService = PacbioRunDirectoryNamesService(
run_directory=run_dir.as_posix()
)

Expand Down

0 comments on commit 4e1977f

Please sign in to comment.