Skip to content

Commit

Permalink
Fix typo in Mutant QC constant (#3901)(patch)
Browse files Browse the repository at this point in the history
### Fixed

- Typo in mutant QC constant `FRACTION_OF_SAMPLES_WITH_FAILED_QC_THRESHOLD`
  • Loading branch information
beatrizsavinhas authored Oct 30, 2024
1 parent 51364ca commit 142ca9d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cg/constants/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ class MicrosaltAppTags(StrEnum):
class MutantQC:
EXTERNAL_NEGATIVE_CONTROL_READS_THRESHOLD: int = 100000
INTERNAL_NEGATIVE_CONTROL_READS_THRESHOLD: int = 2000
FRACTION_OF_SAMPLES_WITH_FAILED_QC_TRESHOLD: float = 0.2
FRACTION_OF_SAMPLES_WITH_FAILED_QC_THRESHOLD: float = 0.2
QUALITY_REPORT_FILE_NAME: str = f"QC_report{FileExtensions.JSON}"


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def _samples_pass_qc(samples_quality_results: SamplesQualityResults) -> bool:
samples_quality_results.failed_samples_count
/ samples_quality_results.total_samples_count
)
return fraction_failed_samples < MutantQC.FRACTION_OF_SAMPLES_WITH_FAILED_QC_TRESHOLD
return fraction_failed_samples < MutantQC.FRACTION_OF_SAMPLES_WITH_FAILED_QC_THRESHOLD

def _get_internal_negative_control_id_for_case(self, case: Case) -> str:
"""Query lims to retrive internal_negative_control_id for a mutant case sequenced in one pool."""
Expand Down

0 comments on commit 142ca9d

Please sign in to comment.