Add 1D interpolation and Bilinear interpolation
#3
Conversation
sriharshakandala
force-pushed
the
sk/add_1dinterpolation
branch
from
be3133c to
acc45fc
Compare
sriharshakandala
force-pushed
the
sk/add_1dinterpolation
branch
from
acc45fc to
a5735a2
Compare
sriharshakandala
changed the title
1D interpolation and Bilinear interpolation
|
Can we please break up this PR into one that adds the boiler plate, and another that adds implementations? |
| println( | ||
| "interpolation time = $(Statistics.median(trial_ml_cpu_ft64_interp)) on CPU for $nlevels levels with Float64\nConstructor time = $(Statistics.median(trial_ml_cpu_ft64_cons))", | ||
| ) | ||
| @show "--------------Metal benchmarks---------------" |
There was a problem hiding this comment.
This should throw exceptions on incompatible devices right ? Could we reorganise the tests by available device extensions? (or perhaps renaming the tests is sufficient here)
could not load symbol "MTLCopyAllDevices":
julia: undefined symbol: MTLCopyAllDevices
There was a problem hiding this comment.
I am still working on cleaning up the tests. I will fix this shortly.
| function interpolatebilinear!( | ||
| ftarget::AbstractArray{FT,N}, | ||
| bilinear::B, | ||
| fsource::AbstractArray{FT,N}, |
There was a problem hiding this comment.
Shouldn't we allow the arrays for ftarget and fsource to have different lengths, rather than both being N? E.g. if interpolating from low resolution to high resolution
There was a problem hiding this comment.
It does. Here, N is just the dimension of the array! It just expects the arrays for the source and target to have the same number of dimensions.
It expects the source functions and target functions to be of sizes (n1, n2, ..., nh1_source, nh2_source) and (n1, n2, ...., nh2_target, nh2_target) respectively. It expects the horizontal dimensions at the end.
There was a problem hiding this comment.
Please take a look at the tests here: test/bilinearinterpolation.jl for an example.
|
@juliasloan25 : I started a draft PR splitting off the 1D interpolation code here: #6 |
Purpose
Add 1D interpolation.