Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure output directory #1106

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Restructure output directory #1106

merged 1 commit into from
Dec 7, 2024

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Dec 3, 2024

And don't use atmos.p.output_dir

The output structure looks like this:

coupler_output_dir_amip/
├── checkpoints
│       └── checkpoints for the various models
├── output_0000/
│   ├── atmos/
│   │   └── output of the atmos model
│   └── ocean/
│       └── output of the ocean model
├── output_0001/
│   └── ... component model outputs in their folders ...
├── output_0002/
│   └── ... component model outputs in their folders ...
└── output_active -> output_0002/

This is needed both to better support checkpoints and to reduce dependency on the atmos cache

@Sbozzolo Sbozzolo force-pushed the gb/outputdir branch 3 times, most recently from b8fa5f8 to fb1cdc9 Compare December 4, 2024 17:27
@Sbozzolo Sbozzolo requested a review from juliasloan25 December 4, 2024 17:42
@Sbozzolo Sbozzolo marked this pull request as ready for review December 4, 2024 17:42
src/Utilities.jl Outdated Show resolved Hide resolved
src/Utilities.jl Show resolved Hide resolved
experiments/ClimaEarth/run_amip.jl Outdated Show resolved Hide resolved
experiments/ClimaEarth/run_amip.jl Outdated Show resolved Hide resolved
experiments/ClimaEarth/run_amip.jl Outdated Show resolved Hide resolved
experiments/ClimaEarth/run_amip.jl Outdated Show resolved Hide resolved
experiments/ClimaEarth/run_amip.jl Outdated Show resolved Hide resolved
experiments/ClimaEarth/run_amip.jl Show resolved Hide resolved
@Sbozzolo Sbozzolo force-pushed the gb/outputdir branch 3 times, most recently from 7acff8d to a721ffe Compare December 4, 2024 23:43
@Sbozzolo Sbozzolo requested a review from juliasloan25 December 4, 2024 23:43
@juliasloan25
Copy link
Member

Can you update NEWS.md before merging please?

@Sbozzolo Sbozzolo enabled auto-merge December 5, 2024 16:13
@Sbozzolo Sbozzolo force-pushed the gb/outputdir branch 5 times, most recently from 89a116f to d9f65ad Compare December 6, 2024 17:22
And don't use `atmos.p.output_dir`

The output structure looks like this:
```
coupler_output_dir_amip/
├── checkpoints
│       └── checkpoints for the various models
├── output_0000/
│   ├── atmos/
│   │   └── output of the atmos model
│   └── ocean/
│       └── output of the ocean model
├── output_0001/
│   └── ... component model outputs in their folders ...
├── output_0002/
│   └── ... component model outputs in their folders ...
└── output_active -> output_0002/
```
@Sbozzolo Sbozzolo merged commit 5d528f1 into main Dec 7, 2024
9 checks passed
@Sbozzolo Sbozzolo deleted the gb/outputdir branch December 7, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants