-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure output directory #1106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61c39c0
to
3f83442
Compare
b8fa5f8
to
fb1cdc9
Compare
fb1cdc9
to
29b9b9d
Compare
juliasloan25
reviewed
Dec 4, 2024
7acff8d
to
a721ffe
Compare
juliasloan25
approved these changes
Dec 5, 2024
Can you update NEWS.md before merging please? |
2aa2e6c
to
b77d68d
Compare
89a116f
to
d9f65ad
Compare
And don't use `atmos.p.output_dir` The output structure looks like this: ``` coupler_output_dir_amip/ ├── checkpoints │ └── checkpoints for the various models ├── output_0000/ │ ├── atmos/ │ │ └── output of the atmos model │ └── ocean/ │ └── output of the ocean model ├── output_0001/ │ └── ... component model outputs in their folders ... ├── output_0002/ │ └── ... component model outputs in their folders ... └── output_active -> output_0002/ ```
d9f65ad
to
b599c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And don't use
atmos.p.output_dir
The output structure looks like this:
This is needed both to better support checkpoints and to reduce dependency on the atmos cache