Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove output_dir from cache #3465

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Remove output_dir from cache #3465

merged 1 commit into from
Dec 5, 2024

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Dec 3, 2024

Output dir is constant and is only used for a callback and the diagnostics

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Dec 3, 2024

CliMA/ClimaCoupler.jl#1106 fixes the ClimaCoupler downstream test

@Sbozzolo Sbozzolo requested a review from juliasloan25 December 3, 2024 22:25
@Sbozzolo Sbozzolo marked this pull request as ready for review December 3, 2024 22:25
@Sbozzolo Sbozzolo added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 5, 2024
Output dir is constant and is only used for a couple of callbacks
@Sbozzolo Sbozzolo force-pushed the gb/output_dir_cache branch from c31a7ba to b7192a9 Compare December 5, 2024 15:56
@Sbozzolo Sbozzolo enabled auto-merge December 5, 2024 15:56
@Sbozzolo Sbozzolo added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit c6f4c71 Dec 5, 2024
15 of 16 checks passed
@Sbozzolo Sbozzolo deleted the gb/output_dir_cache branch December 5, 2024 18:57
@juliasloan25 juliasloan25 mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants