Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix incorrect default config definitions for chart legends #1594

Merged
merged 9 commits into from
Sep 12, 2024
Merged

bug: fix incorrect default config definitions for chart legends #1594

merged 9 commits into from
Sep 12, 2024

Commits on Sep 12, 2024

  1. bug: fix incorrect default config definitions for legends

    @ClementTsang
    ClementTsang committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    74d3a11 View commit details
    Browse the repository at this point in the history

  2. add test to check this in the future

    @ClementTsang
    ClementTsang committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    dc25f66 View commit details
    Browse the repository at this point in the history

  3. add another e2e test to generate and check the default config

    @ClementTsang
    ClementTsang committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    97f8134 View commit details
    Browse the repository at this point in the history

  4. some cleanup

    @ClementTsang
    ClementTsang committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9f9bf0d View commit details
    Browse the repository at this point in the history

  5. some fixes

    @ClementTsang
    ClementTsang committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    62f7700 View commit details
    Browse the repository at this point in the history

  6. skip that test if no default features

    @ClementTsang
    ClementTsang committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0510870 View commit details
    Browse the repository at this point in the history

  7. also update some comments

    @ClementTsang
    ClementTsang committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7ce39c5 View commit details
    Browse the repository at this point in the history

  8. regenerate default config

    @ClementTsang
    ClementTsang committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    26b390a View commit details
    Browse the repository at this point in the history

  9. fix some more errors

    @ClementTsang
    ClementTsang committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b368e7f View commit details
    Browse the repository at this point in the history