Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix incorrect default config definitions for chart legends #1594

Merged
merged 9 commits into from
Sep 12, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Sep 12, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

I had changed how this was parsed in-code but I forgot to update the default configs. This also adds some e2e tests to hopefully catch this all for real in the future, since the schema ones don't catch this stuff and the constants test doesn't actually run the binary for a proper e2e test.

Issue

If applicable, what issue does this address?

From a discussion in #1592

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.51%. Comparing base (3edf430) to head (b368e7f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/options.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1594      +/-   ##
==========================================
- Coverage   54.53%   54.51%   -0.02%     
==========================================
  Files         114      114              
  Lines       17672    17672              
==========================================
- Hits         9637     9634       -3     
- Misses       8035     8038       +3     
Flag Coverage Δ
macos-12 37.27% <0.00%> (ø)
ubuntu-latest 56.93% <0.00%> (-0.02%) ⬇️
windows-2019 37.22% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang changed the title bug: fix incorrect default config definitions for legends bug: fix incorrect default config definitions for chart legends Sep 12, 2024
@ClementTsang ClementTsang merged commit 4e47f9b into main Sep 12, 2024
36 checks passed
@ClementTsang ClementTsang deleted the update_default_config_legend branch September 12, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant