Added checkbox for keeping service running background after GUI closes #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChiaMineJP
changed the title
|
This pull request fixes 1 alert when merging beb580c into 054d7b3 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 58dba07 into 054d7b3 - view on LGTM.com fixed alerts:
|
ChiaMineJP
added
PR ready
|
This pull request fixes 1 alert when merging 79af9ca into d714c21 - view on LGTM.com fixed alerts:
|
DemoThis video demonstrates how this PR works.
Instant_GUI_close.mp4 |
ChiaMineJP
force-pushed
the
keep-service-running-after-app-closes
branch
from
79af9ca to
4fa4770
Compare
|
This pull request fixes 1 alert when merging 4fa4770 into 85231de - view on LGTM.com fixed alerts:
|
ChiaMineJP
force-pushed
the
keep-service-running-after-app-closes
branch
from
4fa4770 to
d166c38
Compare
paninaro
reviewed
Dec 11, 2023
paninaro
approved these changes
Dec 11, 2023
Starttoaster
pushed a commit
that referenced
this pull request
Feb 21, 2024
* Revert "Merge pull request #2269 from Chia-Network/cmj.fix-electron-not-closing" This reverts commit bda1eab, reversing changes made to abb10ab. * Revert "Merge pull request #2268 from Chia-Network/cmj.spawn-detached-daemon" This reverts commit abb10ab, reversing changes made to b8dbb83. * Revert "Added checkbox for keeping service running background after GUI closes (#670)" This reverts commit 481690a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Alert
Users may easily forget that they have Chia services running in the background, even when they're trying to update the app. Perhaps it would be beneficial to notify people to ensure they shut down the Chia-blockchain app.