Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert leave services running #2280

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Feb 21, 2024

⚠️ When checkpointing, this should be a noop. The changes are being removed from the release branch but the issues will be fixed for main.


…ot-closing"

This reverts commit bda1eab, reversing
changes made to abb10ab.
…-daemon"

This reverts commit abb10ab, reversing
changes made to b8dbb83.
@ChiaMineJP
Copy link
Contributor

ChiaMineJP commented Feb 21, 2024

@altendky I've checked the diff between GUI submodule ref in chia-blockchain's latest branch and release/2.2.0.
2d1e051...release/2.2.0
And confirmed that

  • Other than Keep services running in the background thing, extra unexpected code was not removed
  • All modifications related to the Keep services running in the background thing was removed

@altendky altendky marked this pull request as ready for review February 21, 2024 14:35
@ChiaMineJP
Copy link
Contributor

ChiaMineJP commented Feb 21, 2024

Confirmed the GUI to launch / close (without keep service ... checkbox) on

  • Windows 10 -> OK
  • M1 MacOS -> OK
  • Ubuntu 22.04 -> OK
  • Fedora 35 -> OK (There was a problem before succeeded. See details below)

@ChiaMineJP
Copy link
Contributor

ChiaMineJP commented Feb 21, 2024

Umm. Encountered problem on Fedora 35.
daemon did not launch along with GUI.

Update: This seems to be a local enviroment issue. 2.1.4 produced the same error.
Update2: The npm version on my Fedora was 8 which is not supported. Trying with the latest npm version.

Final: Succeeded to launch GUI as expected but it required a special approach.
Except for my Fedora 35 I launch GUI on *nix system as follows:

cd chia-blockchain
git checkout release/2.2.0
./install.sh -d
cd chia-blockchain-gui
git checkout revert_leave_services_running
npm i
npm run build:skipLocales # Avoid to build locale files for build speed
npx lerna run dev:skipLocales --scope=@chia-network/gui

But my Fedora 35 won't launch Electron GUI. I needed to change the way to launch it.

# ...
git checkout revert_leave_services_running
npm i
npm run build # Build locale files
npm run electron # Do not run dev server. Just launch electron and load main html file

At least this is not a regression since I encountered the same trouble when I checked out files used in 2.1.4

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@Starttoaster Starttoaster merged commit 82168f1 into release/2.2.0 Feb 21, 2024
13 checks passed
@Starttoaster Starttoaster deleted the revert_leave_services_running branch February 21, 2024 19:36
@felixbrucker
Copy link

Will the "keep services running" feature be re-added in the future?

@hoffmang9
Copy link
Member

Should make the next release

@felixbrucker
Copy link

great thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants