chore(dot/parachain): consistently use ParaID type #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haikoschol
requested review from
EclesioMeloJunior,
jimjbrettj,
timwu20 and
kishansagathiya
as code owners
haikoschol
requested review from
axaysagathiya and
kishansagathiya
and removed request for
timwu20,
kishansagathiya,
EclesioMeloJunior and
jimjbrettj
haikoschol
force-pushed
the
haiko/para-id
branch
2 times, most recently
from
b09e34f
to
a4a78ab
Compare
haikoschol
force-pushed
the
haiko/para-id
branch
from
a4a78ab
to
adcc739
Compare
kishansagathiya
approved these changes
Oct 28, 2024
EclesioMeloJunior
approved these changes
Oct 29, 2024
haikoschol
force-pushed
the
haiko/para-id
branch
from
c912751
to
adcc739
Compare
edwardmack
approved these changes
Oct 29, 2024
|
TestCandidateValidation_processMessageValidateFromChainState test fails because of We will have to modify the test to include the mock instance as one of the test-case fields. Each test case will have its own mock instance, so we can run all test cases in parallel. |
Some changes to parachaintypes.ParaID were missing in mocked calls, which let to the tests not terminating in GitHub Actions. The fix slightly changes the semantics of the tests in TestCandidateValidation_processMessageValidateFromChainState. Before, one candidate validation subsystem was created and used for all subtests. Now one is created for each subtest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
No functional changes, just mechanically replacing
uint32withparachaintypes.ParaID.Tests
go test ./...Issues
Closes #3883