test(dot/parachain/candidate-validation): disable parallel execution

ChainSafe · Oct 29, 2024 · c912751 · c912751
1 parent adcc739
commit c912751
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 18 deletions.
diff --git a/dot/parachain/candidate-validation/candidate_validation_test.go b/dot/parachain/candidate-validation/candidate_validation_test.go
@@ -109,8 +109,6 @@ func TestCandidateValidation_wasm_invalid_magic_number(t *testing.T) {
 }
 
 func TestCandidateValidation_processMessageValidateFromExhaustive(t *testing.T) {
-	t.Parallel()
-
 	candidateReceipt, validationCode := createTestCandidateReceiptAndValidationCodeWParaId(t, 1000)
 	candidateReceipt2 := candidateReceipt
 	candidateReceipt2.Descriptor.PovHash = common.MustHexToHash(
@@ -254,7 +252,6 @@ func TestCandidateValidation_processMessageValidateFromExhaustive(t *testing.T)
 	for name, tt := range tests {
 		tt := tt
 		t.Run(name, func(t *testing.T) {
-			t.Parallel()
 			overseerToSubsystem <- tt.msg
 			result := <-sender
 			require.Equal(t, tt.want, result)
@@ -263,8 +260,6 @@ func TestCandidateValidation_processMessageValidateFromExhaustive(t *testing.T)
 }
 
 func TestCandidateValidation_processMessageValidateFromChainState(t *testing.T) {
-	t.Parallel()
-
 	candidateReceipt, validationCode := createTestCandidateReceiptAndValidationCodeWParaId(t, 1000)
 	candidateReceipt2 := candidateReceipt
 	candidateReceipt2.Descriptor.PovHash = common.MustHexToHash(
@@ -498,8 +493,6 @@ func TestCandidateValidation_processMessageValidateFromChainState(t *testing.T)
 	for name, tt := range tests {
 		tt := tt
 		t.Run(name, func(t *testing.T) {
-			t.Parallel()
-
 			sender := make(chan parachaintypes.OverseerFuncRes[ValidationResult])
 			tt.msg.Ch = sender
 
@@ -511,7 +504,6 @@ func TestCandidateValidation_processMessageValidateFromChainState(t *testing.T)
 }
 
 func Test_precheckPvF(t *testing.T) {
-	t.Parallel()
 	ctrl := gomock.NewController(t)
 	t.Cleanup(ctrl.Finish)
 	candidate, validationCode := createTestCandidateReceiptAndValidationCodeWParaId(t, 1000)
@@ -615,8 +607,6 @@ func Test_precheckPvF(t *testing.T) {
 		tt := tt
 
 		t.Run(name, func(t *testing.T) {
-			t.Parallel()
-
 			candidateValidationSubsystem := CandidateValidation{
 				pvfHost:    newValidationHost(),
 				BlockState: mockBlockState,

diff --git a/dot/parachain/candidate-validation/host_test.go b/dot/parachain/candidate-validation/host_test.go
@@ -11,7 +11,6 @@ import (
 )
 
 func TestHost_validate(t *testing.T) {
-	t.Parallel()
 	candidateReceipt, validationCode := createTestCandidateReceiptAndValidationCodeWParaId(t, 1000)
 	candidateReceipt2 := candidateReceipt
 	candidateReceipt2.Descriptor.PovHash = common.MustHexToHash(
@@ -202,8 +201,6 @@ func TestHost_validate(t *testing.T) {
 	for name, tt := range tests {
 		tt := tt
 		t.Run(name, func(t *testing.T) {
-			t.Parallel()
-
 			taskResult, err := pvfHost.validate(tt.validationTask)
 
 			require.NoError(t, err)
@@ -214,7 +211,6 @@ func TestHost_validate(t *testing.T) {
 }
 
 func TestHost_performBasicChecks(t *testing.T) {
-	t.Parallel()
 	paramsTooLarge := ParamsTooLarge
 	povHashMismatch := PoVHashMismatch
 	codeHashMismatch := CodeHashMismatch
@@ -316,7 +312,6 @@ func TestHost_performBasicChecks(t *testing.T) {
 	for name, tt := range tests {
 		tt := tt
 		t.Run(name, func(t *testing.T) {
-			t.Parallel()
 			validationError, internalError := performBasicChecks(tt.args.candidate, tt.args.maxPoVSize, tt.args.pov,
 				tt.args.validationCodeHash)
 			require.NoError(t, internalError)

diff --git a/dot/parachain/candidate-validation/worker_pool_test.go b/dot/parachain/candidate-validation/worker_pool_test.go
@@ -21,7 +21,6 @@ func createTestValidationCode(t *testing.T) parachaintypes.ValidationCode {
 }
 
 func TestValidationWorkerPool_newValidationWorker(t *testing.T) {
-	t.Parallel()
 	testValidationCode := createTestValidationCode(t)
 
 	cases := map[string]struct {
@@ -53,8 +52,6 @@ func TestValidationWorkerPool_newValidationWorker(t *testing.T) {
 	for tname, tt := range cases {
 		tt := tt
 		t.Run(tname, func(t *testing.T) {
-			t.Parallel()
-
 			workerPool := tt.setupWorkerPool(t)
 
 			require.ElementsMatch(t,