Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update golangci-lint to v1.6.1 #4222

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

timwu20
Copy link
Contributor

@timwu20 timwu20 commented Oct 3, 2024

Changes

  • updates golangci-lint to latest release v1.6.1
  • adds nolint: lines to existing issues in the codebase
  • fixes a few issues

Tests

go test -tags integration github.com/ChainSafe/gossamer

@timwu20 timwu20 changed the title chore: update golangci-lint to v1.61 chore: update golangci-lint to v1.6.1 Oct 3, 2024
.gitignore Outdated Show resolved Hide resolved
Copy link
Contributor

@axaysagathiya axaysagathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I have observed, it seems you have added //nolint:gosec wherever we have type Casting.

Is it possible to configure the linter so that it does not throw a lint error for type casting?

.gitignore Outdated Show resolved Hide resolved
dot/network/block_announce.go Show resolved Hide resolved
@timwu20 timwu20 enabled auto-merge (squash) October 7, 2024 22:05
@timwu20 timwu20 merged commit b6f4df4 into development Oct 7, 2024
24 checks passed
@timwu20 timwu20 deleted the tim/update-golangci-lint branch October 7, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants