Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Go and golangci-lint in GitHub Actions #4196

Closed
haikoschol opened this issue Sep 24, 2024 · 2 comments
Closed

Upgrade Go and golangci-lint in GitHub Actions #4196

haikoschol opened this issue Sep 24, 2024 · 2 comments
Assignees
@haikoschol
Labels
S-ci issue related to continuous integration tasks or piplelines.

Comments

@haikoschol
Copy link
Contributor

Issue summary

  • Upgrade Go to the latest version (currently 1.23.1)
  • Upgrade golangci-lint to the latest version (currently 1.61.0)

Other information and links

Due to the addition of range functions in Go 1.23, the version of golangci-lint we currently use (1.54) panics when run on the Gossamer codebase. The latest version of golangci-lint works, but results in a lot of new issues being flagged. This causes the upgrade to be a bit more work than just a version bump and might cause some conflicts in other currently open PRs.
@haikoschol haikoschol added the S-ci issue related to continuous integration tasks or piplelines. label Sep 24, 2024
@haikoschol
Copy link
Contributor Author

golangci-lint was upgraded in #4222

@haikoschol haikoschol mentioned this issue Oct 15, 2024
Merged
@haikoschol
Copy link
Contributor Author

Go in CI and Dockerfile was upgraded in #4246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haikoschol haikoschol

Labels
S-ci issue related to continuous integration tasks or piplelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@haikoschol