-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib/grandpa): verify GRANDPA justification before applying the block #4144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwu20
force-pushed
the
tim/eclesio/verify-justification
branch
2 times, most recently
from
August 23, 2024 17:49
b7f335e
to
f06b42c
Compare
timwu20
requested review from
EclesioMeloJunior,
jimjbrettj,
kishansagathiya and
P1sar
as code owners
August 24, 2024 02:23
timwu20
changed the title
Tim/eclesio/verify justification
feat(lib/grandpa): verify GRANDPA justification before applying the block
Aug 24, 2024
jimjbrettj
reviewed
Sep 5, 2024
jimjbrettj
reviewed
Sep 5, 2024
jimjbrettj
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small comments, but overall lgtm
timwu20
force-pushed
the
tim/pkg-finality-grandpa
branch
from
September 5, 2024 17:29
b12e34a
to
f5a9fa3
Compare
timwu20
force-pushed
the
tim/eclesio/verify-justification
branch
from
September 5, 2024 17:49
f06b42c
to
0d0794f
Compare
Co-authored-by: JimboJ <[email protected]>
dimartiro
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few nits and some questions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
justification
before applying the block #4084Taken from #4084:
Tests
go test -tags integration github.com/ChainSafe/gossamer
Issues
close #3468