-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib(pkg/finality-grandpa): standalone finality-grandpa package #4126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of heavy use of generics, wonder if there is a simpler way
My opinion on the use of generics here (since I see it discussed above). Currently, I tend to lean away from their use in this package as it does not seem necessary to me and I don't really think we should use them unless there is good reason. However, it is a package so generics can make sense in this context, even if the immediate usefulness isn't there from my pov. So I can understand this. The other point I wanted to make is that the merging of this PR does not mean we can never modify this code again. The main reason this is being merged right now, to begin with, is to help support another PR. So I think discussions around generics, code structure, and other larger discussions that have implications outside of just this PR should be had, but perhaps they are more ongoing conversations rather than explicitly tied to this PR. To be clear, I am fully in favor of discussing these points. I just want to make sure that the context that this PR exists in is considered when deciding if large changes should be prioritized in this PR or handled by future work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted, I have already reviewed this work separately. I still gave it another look over, added a few comments, and contributed to a few ongoing discussions.
This is really awesome work. A ton of work went into this and I am stoked to see it being merged, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already reviewed this PR some time ago
Co-authored-by: Kishan Sagathiya <[email protected]>
Co-authored-by: JimboJ <[email protected]>
b12e34a
to
f5a9fa3
Compare
Changes
feat/grandpa
branch (see lib(pkg): standalonefinality-grandpa
package #3235)Tests
go test -tags integration github.com/ChainSafe/gossamer
Issues
contributes to #3468