Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib(pkg/finality-grandpa): standalone finality-grandpa package #4126

Merged
merged 9 commits into from
Sep 5, 2024

Conversation

timwu20
Copy link
Contributor

@timwu20 timwu20 commented Aug 15, 2024

Changes

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

contributes to #3468

@timwu20 timwu20 changed the title feat(pkg/finality-grandpa): finality-grandpa package feat(pkg/finality-grandpa): standalone finality-grandpa package Aug 15, 2024
@timwu20 timwu20 changed the title feat(pkg/finality-grandpa): standalone finality-grandpa package lib(pkg/finality-grandpa): standalone finality-grandpa package Aug 15, 2024
@timwu20 timwu20 marked this pull request as ready for review August 15, 2024 19:02
pkg/finality-grandpa/bridge_state.go Show resolved Hide resolved
pkg/finality-grandpa/bridge_state.go Outdated Show resolved Hide resolved
pkg/finality-grandpa/bridge_state.go Outdated Show resolved Hide resolved
pkg/finality-grandpa/context.go Outdated Show resolved Hide resolved
pkg/finality-grandpa/context.go Show resolved Hide resolved
pkg/finality-grandpa/past_rounds.go Show resolved Hide resolved
pkg/finality-grandpa/bitfield.go Outdated Show resolved Hide resolved
pkg/finality-grandpa/bitfield.go Show resolved Hide resolved
pkg/finality-grandpa/bitfield.go Show resolved Hide resolved
pkg/finality-grandpa/bitfield_test.go Show resolved Hide resolved
pkg/finality-grandpa/bitfield_test.go Outdated Show resolved Hide resolved
pkg/finality-grandpa/bridge_state.go Outdated Show resolved Hide resolved
pkg/finality-grandpa/bridge_state.go Outdated Show resolved Hide resolved
pkg/finality-grandpa/bridge_state.go Show resolved Hide resolved
pkg/finality-grandpa/bridge_state.go Outdated Show resolved Hide resolved
pkg/finality-grandpa/bridge_state_test.go Show resolved Hide resolved
Copy link
Contributor

@kishansagathiya kishansagathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of heavy use of generics, wonder if there is a simpler way

pkg/finality-grandpa/weights.go Show resolved Hide resolved
pkg/finality-grandpa/voting_round.go Outdated Show resolved Hide resolved
pkg/finality-grandpa/voting_round.go Show resolved Hide resolved
pkg/finality-grandpa/voter_test.go Show resolved Hide resolved
pkg/finality-grandpa/voter.go Show resolved Hide resolved
pkg/finality-grandpa/voter.go Show resolved Hide resolved
@jimjbrettj
Copy link
Contributor

My opinion on the use of generics here (since I see it discussed above).

Currently, I tend to lean away from their use in this package as it does not seem necessary to me and I don't really think we should use them unless there is good reason. However, it is a package so generics can make sense in this context, even if the immediate usefulness isn't there from my pov. So I can understand this.

The other point I wanted to make is that the merging of this PR does not mean we can never modify this code again. The main reason this is being merged right now, to begin with, is to help support another PR. So I think discussions around generics, code structure, and other larger discussions that have implications outside of just this PR should be had, but perhaps they are more ongoing conversations rather than explicitly tied to this PR.

To be clear, I am fully in favor of discussing these points. I just want to make sure that the context that this PR exists in is considered when deciding if large changes should be prioritized in this PR or handled by future work.

Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted, I have already reviewed this work separately. I still gave it another look over, added a few comments, and contributed to a few ongoing discussions.

This is really awesome work. A ton of work went into this and I am stoked to see it being merged, LGTM!

Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed this PR some time ago

@timwu20 timwu20 merged commit 646a445 into development Sep 5, 2024
24 checks passed
@timwu20 timwu20 deleted the tim/pkg-finality-grandpa branch September 5, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants