test(rpc): rpc unit tests with db snapshot #5034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
force-pushed
the
hm/rpc-snaphsot-unittest
branch
from
4a2bd96 to
2936e3d
Compare
hanabi1224
commented
Dec 4, 2024
| @@ -0,0 +1,2 @@ | |||
| f3_gettipsetbyepoch_1730952732441851.json.zst | |||
There was a problem hiding this comment.
The list is to be expanded.
hanabi1224
requested review from
lemmih and
sudo-shashank
and removed request for
a team
lemmih
reviewed
Dec 4, 2024
| }; | ||
| let snapshot: RpcCallSnapshot = serde_json::from_slice(snapshot_bytes.as_slice())?; | ||
| let db_bytes = BASE64_STANDARD.decode(&snapshot.db)?; | ||
| let db = Arc::new(match MemoryDB::deserialize_from(db_bytes.as_slice()) { |
There was a problem hiding this comment.
Can we use CAR files rather than serialized memory-dbs?
There was a problem hiding this comment.
Yes, that's doable. The only downside is that CAR DB is not capable of storing non-content-addressable data(e.g. HEAD -> head_tsk) thus at least 2 files(CAR db, and setting DB+request+desired response) are required for a test case, while with the current solution a single test-snap file is sufficient.
hanabi1224
force-pushed
the
hm/rpc-snaphsot-unittest
branch
2 times, most recently
from
9ae33bd to
5a74d49
Compare
hanabi1224
force-pushed
the
hm/rpc-snaphsot-unittest
branch
from
5a74d49 to
f5d98d7
Compare
3 tasks
sudo-shashank
approved these changes
Dec 6, 2024
4 tasks
|
Superseded by #5074 (Keep open for now just for referencing review comments) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Part of #5046
Changes introduced in this pull request:
forest-tool api test [RPC_SNAPSHOTS]Reference issue to close (if applicable)
Closes
Other information and links
Change checklist