-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression testing for RPC methods #4657
Comments
If the required data is larger, perhaps we could move it to a submodule or a downloadable artefact. If all regression snapshots would take less than 1 GB it'd be already great. |
I wonder if we can use some tooling from Lotus for this, see filecoin-project/FIPs#1036 (comment). |
@hanabi1224 do we consider this PR #5034 to close this initiative? |
I think so. |
I missed this issue and created a duplicated one #5046 |
Ok, let's close this one, then. |
Issue summary
Setting up regression tests for bugs in the RPC methods is demanding. It often requires recreating a complicated blockchain state or loading a snapshot file, which can weigh several gigabytes. Most of the data in the snapshot will be unused, though, and if we trim out dead values, the snapshot files may be small enough to be included in the regression tests.
Blockstore
wrapper, which loads a CAR file, keeps track of which keys are accessed, and writes a minimal CAR file when dropped. This new CAR file can then be used in the regression test.Filecoin.StateCirculatingSupply
#4446. This bug is reproducible with a 4GiB snapshot. If the required data can be reduced to a few KiB, it can be included in the repository.Other information and links
The text was updated successfully, but these errors were encountered: