Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom ellipsoids #1432

Merged
merged 28 commits into from
Jun 28, 2024
Merged

Add support for custom ellipsoids #1432

merged 28 commits into from
Jun 28, 2024

Conversation

azrogers
Copy link
Contributor

@azrogers azrogers commented May 24, 2024

Currently, Cesium for Unreal is hardcoded to use the WGS84 ellipsoid. This change adds support for specifying other ellipsoids by creating assets for them and assigning them to georeferences.

Closes #366

Base automatically changed from fix-feature-id to main May 29, 2024 17:07
@azrogers azrogers marked this pull request as ready for review June 17, 2024 18:11
@kring kring added this to the July Release milestone Jun 24, 2024
@csciguy8 csciguy8 self-assigned this Jun 25, 2024
@csciguy8 csciguy8 self-requested a review June 25, 2024 15:59
@csciguy8

This comment was marked as resolved.

@csciguy8

This comment was marked as resolved.

@csciguy8

This comment was marked as resolved.

package-lock.json Outdated Show resolved Hide resolved
csciguy8

This comment was marked as outdated.

@csciguy8 csciguy8 assigned azrogers and unassigned csciguy8 Jun 26, 2024
@azrogers azrogers requested a review from csciguy8 June 26, 2024 22:24
@azrogers

This comment was marked as outdated.

@csciguy8

This comment was marked as resolved.

@azrogers

This comment was marked as outdated.

@azrogers

This comment was marked as resolved.

@csciguy8

This comment was marked as resolved.

@azrogers
Copy link
Contributor Author

@csciguy8 Made GetNativeEllipsoid return a const ref, made UCesiumEllipsoid store a TOptional instead of a TUniquePtr, fixed the OnEllipsoidChanged event (apparently the handler needs to be marked with "CallInEditor"), and added a method that reloads any georeferences using an ellipsoid asset when that ellipsoid asset is saved. Should be good to go!

@azrogers azrogers requested a review from csciguy8 June 28, 2024 17:31
Copy link
Contributor

@csciguy8 csciguy8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @azrogers!

Will merge once CI passes (almost done).

Kudos for catching the event when the ellipsoid data changes. UCesiumEllipsoid::PostSaveRoot does not look like an easy or obvious way to handle this

@csciguy8 csciguy8 assigned csciguy8 and unassigned azrogers Jun 28, 2024
@csciguy8 csciguy8 merged commit 0c619da into main Jun 28, 2024
26 checks passed
@csciguy8 csciguy8 deleted the custom-ellipsoid branch June 28, 2024 21:03
@csciguy8 csciguy8 removed their assignment Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to choose a custom ellipsoid
3 participants