-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom ellipsoids in Unity #465
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @azrogers !
Will merge once the final CI run completes.
Did encounter a minor refresh issue during testing. If I used a custom ellipsoid, then edited it, the tileset wouldn't refresh. I would have to manually click "Refresh Tileset". Not really sure if this is fixable, and doesn't seem substantial enough to block this PR.
In line with CesiumGS/cesium-unreal#1432 and CesiumGS/cesium-native#890, this change lets the Unity runtime support custom ellipsoids by creating ScriptableObjects for them and specifying those assets on CesiumGeoreference components.