Support custom ellipsoids in Unity #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
csciguy8
reviewed
Jun 26, 2024
This comment was marked as resolved.
This comment was marked as resolved.
csciguy8
reviewed
Jun 26, 2024
This comment was marked as resolved.
This comment was marked as resolved.
csciguy8
reviewed
Jun 26, 2024
csciguy8
reviewed
Jun 26, 2024
csciguy8
reviewed
Jun 26, 2024
csciguy8
reviewed
Jun 26, 2024
csciguy8
reviewed
Jun 26, 2024
csciguy8
reviewed
Jun 26, 2024
csciguy8
reviewed
Jun 26, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
csciguy8
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Looks great @azrogers !
Will merge once the final CI run completes.
Did encounter a minor refresh issue during testing. If I used a custom ellipsoid, then edited it, the tileset wouldn't refresh. I would have to manually click "Refresh Tileset". Not really sure if this is fixable, and doesn't seem substantial enough to block this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with CesiumGS/cesium-unreal#1432 and CesiumGS/cesium-native#890, this change lets the Unity runtime support custom ellipsoids by creating ScriptableObjects for them and specifying those assets on CesiumGeoreference components.