Fix incorrect ECEF->LLH transformation in CesiumCartographicPolygon. #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@csciguy8 can you please review and merge this one today so that we can include it in tomorrow's release? |
csciguy8
reviewed
Jul 31, 2024
| @@ -138,7 +138,7 @@ internal List<double2> GetCartographicPoints(Matrix4x4 worldToTileset) | |||
| float3 worldPosition = knot.Transform(localToWorld).Position; | |||
| float3 unityPosition = worldToTileset.MultiplyPoint3x4(worldPosition); | |||
| double3 ecefPosition = georeference.TransformUnityPositionToEarthCenteredEarthFixed(unityPosition); | |||
| double3 cartographicPosition = georeference.ellipsoid.LongitudeLatitudeHeightToCenteredFixed(ecefPosition); | |||
| double3 cartographicPosition = georeference.ellipsoid.CenteredFixedToLongitudeLatitudeHeight(ecefPosition); | |||
There was a problem hiding this comment.
I checked the original PR that introduced this bug.
Pretty sure it was just a typo that the author and reviewer (me!) both missed.
I also looked at the diffs for that PR again to make sure there weren't similar instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #465,
CesiumCartographicPolygonwas incorrectly callingLongitudeLatitudeHeightToCenteredFixedwhen attempting to transform ECEF to Longitude/Latitude/Height. That is, it was transforming in the wrong direction. This made the vertex positions in the polygon incorrect, breaking the polygon functionality completely.Reported here:
https://community.cesium.com/t/cesiumpolygonrasteroverlay-can-not-clip-vectortilemap-in-v1-11/34093