Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TimeInUse signal for ElectricMotor #725

Merged
merged 1 commit into from
Mar 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions spec/Powertrain/ElectricMotor.vspec
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ Speed:
unit: rpm
description: Motor rotational speed measured as rotations per minute. Negative values indicate reverse driving mode.

TimeInUse:
datatype: float
type: sensor
description: Accumulated time during engine lifetime when the vehicule state's is 'READY'.
comment: Vehicles may define their READY state.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we see a need to add an iSReady signal as well (in this file and/or on vehicle level)? I do not know how common the term is - and if so if there is a common definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any use for it at the moment, and if it were to be added, I think it would have to be part of another Pull Request.

unit: h

#
# Motor temperature
Expand Down