Introduce TimeInUse signal for ElectricMotor

[JonathanForce]

Description

It would be interesting to know the engine hours for electric motor.

[erikbosch]

Looks good to me, will bring it up on the VSS meeting today.
You need to add a sign-off to the commit, for example with git commit -s --amend and then a force push

See https://covesa.global/contribute

[JonathanForce]

Thank you @erikbosch

[erikbosch]

MoM:

• Adnan: Possible remove the term engine, call it "motor hours", "active hours", "running hours", "hours in use"
• Possibly "Time in use"
• Adnan: Do use EV use rotation as criteria?
• Erik: When do we want to increase timer, only when motor rotating, or rather some status ("ready")
• Please review

[erikbosch]

Do we see a need to add an iSReady signal as well (in this file and/or on vehicle level)? I do not know how common the term is - and if so if there is a common definition.

[JonathanForce]

We don't have any use for it at the moment, and if it were to be added, I think it would have to be part of another Pull Request.

[erikbosch]

MoM:

• Jonathon: For us READY state is that if gas pedal is pressed vehicle will move. But definition can vary
• Daniel: Unclear from when it is measured
• J: Total time in use
• Erik: Shall Park be considered READY?
• Nick: In my vauxhall when moved out of Park
• S: Also charging is part of vehicle lifetime
• Please continue review/discuss, lets continue discussion on next meeting

[JonathanForce]

MoM:

• Jonathon: For us READY state is that if gas pedal is pressed vehicle will move. But definition can vary
• Daniel: Unclear from when it is measured
• J: Total time in use
• Erik: Shall Park be considered READY?
• Nick: In my vauxhall when moved out of Park
• S: Also charging is part of vehicle lifetime
• Please continue review/discuss, lets continue discussion on next meeting

Let's start from the beginning.

What we want:
For electric vehicles, we want to determine a degree of wear on parts based on how long the vehicle has been in use.

What is the trigger:
We want this time to increase as soon as the vehicle is ON and the transmission is not in the 'Park' position.
So, the condition is 'Transmission.SelectedGear' is not '126=Park’.

A question was about the charging time. If you want this signal to remove an ambiguity, we can add a ‘TimeInCharge’ signal based on the ‘Charging.IsCharging’ signal.

[erikbosch]

This signal is now well defined. At last meeting there were some discussions on use-cases for it. I have no problem to see potential use-cases, it nothing else to collect statistics on time-in-use vs. wear and problems with vehicles. That off course does not mean that all parties interested in VSS may find it useful, but that is the same for many other signals.

[erikbosch]

MoM:

• Stefan: Terminal50 (Klemme 50) could be used - if you turn key you have ACC on first step, then ON, think it is standard. Also others exist like Terminal30 (permanent).
• Erik: Partially different criteria compared to using gear!=park
• Stefan: Also electrical components degrade, not only motor
• Pierre: What is use case?
• Jonathan: Do not want to increment timer if just listening at radio
• J: At BRP we use hydrofoils and other non-standard vehicle types
• S: You want to know when high voltage connection is closed/engaged.
• E: Do not know how EV handle if it is "Park" for a long while, does it turn off (disengage) the EV-drive.
• E: An alternative would be to have it less general, like "READY" in a previous commit version
• P: Would be fine to leave it to OEM decide.
• P: But could good to be document why it useful:
• E: AP Jonathan; Change to "READY", add rationale for why signal is useful as comment
• J: That was my first proposal, but comment for current solution last week
• J: I can update but I will not participate in meetings onward
• E: AP Jonathan to update
• Merge discussion next week

[erikbosch]

LGTM

[erikbosch]

MoM: Merge