Skip to content

[PLT-1299]. Cluster changes for ecs service module #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 7, 2025
Merged

[PLT-1299]. Cluster changes for ecs service module #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41d3af6
Cluster changes for plt-1299
juliareynolds-nava Sep 24, 2025
d380134
Merge branch 'main' into plt-1299_cluster_fixes
juliareynolds-nava Sep 26, 2025
186f9af
type for kms_alias
juliareynolds-nava Sep 26, 2025
e83155e
provide target key arn for platform
juliareynolds-nava Sep 26, 2025
553b583
Merge branch 'main' into plt-1299_cluster_fixes
juliareynolds-nava Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions terraform/modules/cluster/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,6 @@ module "cluster" {
platform = module.platform
}

resource "aws_ecs_service" "contracts" {
name = "${local.service_prefix}-contracts"
cluster = module.cluster.this.id
task_definition = aws_ecs_task_definition.contracts.arn
desired_count = 1
launch_type = "FARGATE"
platform_version = "1.4.0"
propagate_tags = "SERVICE"
}
```

<!-- BEGIN_TF_DOCS -->
Expand Down
10 changes: 9 additions & 1 deletion terraform/modules/cluster/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
variable "platform" {
description = "Object that describes standardized platform values."
type = any
type = object({
app = string,
env = string,
kms_alias_primary = object({
target_key_arn = string,
}),
service = string,
is_ephemeral_env = string
})
}

variable "cluster_name_override" {
Expand Down