-
Notifications
You must be signed in to change notification settings - Fork 0
[PLT-1299]. Cluster changes for ecs service module #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For validation, you could run a plan with the ref updated to this branch at https://github.com/CMSgov/ab2d/blob/66206f254794fecac59f95a99e104ee24306a868/ops/services/20-microservices/main.tf#L52
@gsf I uploaded the plan results to the PR description. |
## 🎫 Ticket https://jira.cms.gov/browse/PLT-1299 ## 🛠 Changes Expanded platform variable and edited readme ## ℹ️ Context These changes are for the ecs service module. ## 🧪 Validation <details> <summary>Tofu Plan Output</summary> ``` OpenTofu will perform the following actions: # aws_ecs_service.worker will be updated in-place ~ resource "aws_ecs_service" "worker" { id = "arn:aws:ecs:us-east-1:***:service/ab2d-test-worker/ab2d-test-worker" name = "ab2d-test-worker" tags = {} ~ task_definition = "arn:aws:ecs:us-east-1:***:task-definition/ab2d-test-worker:227" -> (known after apply) # (17 unchanged attributes hidden) # (3 unchanged blocks hidden) } # aws_ecs_task_definition.worker must be replaced -/+ resource "aws_ecs_task_definition" "worker" { ~ arn = "arn:aws:ecs:us-east-1:***:task-definition/ab2d-test-worker:227" -> (known after apply) ~ arn_without_revision = "arn:aws:ecs:us-east-1:***:task-definition/ab2d-test-worker" -> (known after apply) ~ container_definitions = jsonencode( ~ [ ~ { ~ environment = [ # (12 unchanged elements hidden) { name = "AWS_SQS_URL" value = "https://sqs.us-east-1.amazonaws.com/***/ab2d-test-events" }, ~ { name = "IMAGE_VERSION" ~ value = "ab2d-worker-1626-merge-682775a" -> "ab2d-worker-1626-merge-37a4551" }, { name = "MICROSERVICES_URL" value = "http://internal-ab2d-test-microservices-87290984.us-east-1.elb.amazonaws.com/" }, # (1 unchanged element hidden) ] ~ image = "***.dkr.ecr.us-east-1.amazonaws.com/ab2d-worker:ab2d-worker-1626-merge-682775a" -> "***.dkr.ecr.us-east-1.amazonaws.com/ab2d-worker:ab2d-worker-1626-merge-37a4551" name = "worker" - portMappings = [] - systemControls = [] - volumesFrom = [] # (5 unchanged attributes hidden) }, ] # forces replacement ) ~ enable_fault_injection = false -> (known after apply) ~ id = "ab2d-test-worker" -> (known after apply) ~ revision = 227 -> (known after apply) - tags = {} -> null # (10 unchanged attributes hidden) - volume { - configure_at_launch = false -> null - name = "efs" -> null - efs_volume_configuration { - file_system_id = "fs-06898a9a35a2a8959" -> null - root_directory = "/" -> null - transit_encryption = "ENABLED" -> null - transit_encryption_port = 0 -> null - authorization_config { - access_point_id = "fsap-09a16152758024a89" -> null } } } - volume { - configure_at_launch = false -> null - name = "newrelic_logs" -> null } - volume { - configure_at_launch = false -> null - name = "tmp" -> null } - volume { - configure_at_launch = false -> null - name = "var_logs" -> null } + volume { + configure_at_launch = (known after apply) + name = "efs" + efs_volume_configuration { + file_system_id = "fs-06898a9a35a2a8959" + root_directory = "/" + transit_encryption = "ENABLED" + transit_encryption_port = 0 + authorization_config { + access_point_id = "fsap-09a16152758024a89" } } } + volume { + configure_at_launch = (known after apply) + name = "newrelic_logs" } + volume { + configure_at_launch = (known after apply) + name = "tmp" } + volume { + configure_at_launch = (known after apply) + name = "var_logs" } } Plan: 1 to add, 1 to change, 1 to destroy. ```
🎫 Ticket
https://jira.cms.gov/browse/PLT-1299
🛠 Changes
Expanded platform variable and edited readme
ℹ️ Context
These changes are for the ecs service module.
🧪 Validation
Tofu Plan Output