Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forecast figure enhancements redux #349

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Conversation

damonbayer
Copy link
Collaborator

@damonbayer damonbayer commented Feb 12, 2025

Closes #167
Closes #331

Example figure:
image (1)

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 92 lines in your changes missing coverage. Please review.

Project coverage is 24.32%. Comparing base (d8534e9) to head (8e3f92f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
hewr/R/make_forecast_figure.R 0.00% 91 Missing ⚠️
pipelines/prep_data.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   25.30%   24.32%   -0.98%     
==========================================
  Files          22       22              
  Lines        1648     1714      +66     
==========================================
  Hits          417      417              
- Misses       1231     1297      +66     
Flag Coverage Δ
hewr 37.44% <0.00%> (-4.24%) ⬇️
pipelines 5.15% <0.00%> (ø)
pyrenew_hew 27.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damonbayer damonbayer marked this pull request as ready for review February 12, 2025 22:27
Copy link
Contributor

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dylanhmorris dylanhmorris merged commit b80ff42 into main Feb 12, 2025
13 of 15 checks passed
@dylanhmorris dylanhmorris deleted the dmb_stamp_pointinterval_plots branch February 12, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate why some plots use "US" while others use "USA" make_forecast_figure enhancements
2 participants